Conversation
philrz
approved these changes
Mar 28, 2024
Contributor
philrz
left a comment
philrz
left a comment
There was a problem hiding this comment.
I tested this out on Windows using an artifact from this Actions run and the editor came up fine with my Internet disconnected. LGTM! 👍
Contributor
Author
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2915
The editor now loads without an internet connection. Instead of reaching out to a CDN, electron intercepts the request and serves it from node modules.
Here is the editor loaded.
And here is the sources tab revealing no network requests.
In order to get this working properly in development, I had to disable web security in the browser windows to allow for cross-origin javascript requests. This is only needed in development because we serve the html from a dev server. In production we serve the files from the same origin that we serve the monaco files, so they are on the same origin already.
I would love to test this in a release to make sure I stitched all the paths together correctly in a release environment.