Conversation
philrz
approved these changes
Feb 26, 2024
Contributor
philrz
left a comment
philrz
left a comment
There was a problem hiding this comment.
I tested it out and it's certainly an improvement over what was there before, so I've clicked Approve.
While I'm commenting though, I figured I'd point out that based on what I can see the width is maybe not quite 100% consistent. Here's the baseline at current tip of main (commit 04c470a) showing the stark contrast in modal width:
04c470a.mp4
And on this branch at commit 692c863, the width is mostly the same as I click between the two modes, but I can see a small/subtle change in the width.
692c863.mp4
Figured I'd point it out while you're still under the hood in case you wanna fiddle some more. 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I was making the screen cast to share on twitter, I noticed the export modal changes it's width when you change export destinations between file and pool. This PR gives the export modal a consistent width.