Conversation
nwt
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2914 has the background and repro. The change in this PR is based on what I found in element-hq/element-web#17188 and how they fixed it via https://github.com/vector-im/element-desktop/pull/337/files, since their symptom looks exactly like ours.
I made a Dev build https://github.com/brimdata/zui/actions/runs/7064639612 using the change on this branch and it tested out fine. I used it to repeat the same repro steps shown in the video in #2914 (comment) and none of the
.org.chromium.Chromium.*accumulated this time. The app also ran otherwise healthy, and in particular, I was able to import/query data, which is a sign thatnode-pipe(one of the modules now subject to different packaging) was still working fine, since it's my understanding that the successful launch of thezed serveprocess is dependent on that.On my Linux VM I also did a
findof the contents below/opt/Zui/resourceswith GA Zui v1.4.1 and then also with the Dev build just to confirm I saw only the expected differences, and that does seem to be the case.Fixes #2914