Wait for Load Successful to disappear first in pool-loads e2e test#2846
Merged
Wait for Load Successful to disappear first in pool-loads e2e test#2846
Conversation
jameskerr
approved these changes
Aug 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a recent group discussion about some of the approaches proposed to address #2843, @jameskerr expressed a preference for the 2nd proposal that "tagged" queries and their results. However, since implementing that would require @jameskerr to interrupt his other priorities, I went ahead and tested the changes in this PR that are what's described in the 3rd proposal. I tested it out using my Linux VM with the config/script described in #2843 (comment). The tests confirmed that these changes do indeed greatly improve reliability of the test, as a baseline run of the
cycle.shat Zui commit 3d3b66d saw 18 failures out of 200 runs, whereas f9fc137 running thecycle.shat Zui commit f9fc137 from this branch saw 0 failures out of 200 runs.I still feel that we'll ultimately want to go ahead with the 2nd proposal from #2843 since that would potentially help all tests that issue queries and check results whereas the changes in this PR just improve one particular test. However, since these changes should greatly reduce the number of e2e failures in the meantime, I'm game to see them merged.