Skip to content

Only use Meta+KeyA combo to Select All on macOS#2842

Merged
philrz merged 1 commit intomainfrom
e2e-fix-select-all
Aug 25, 2023
Merged

Only use Meta+KeyA combo to Select All on macOS#2842
philrz merged 1 commit intomainfrom
e2e-fix-select-all

Conversation

@philrz
Copy link
Contributor

@philrz philrz commented Aug 20, 2023

The e2e tests recently started showing consistent failures in Actions with this symptom:

  3) queries.spec.ts:18:3 › Query tests › session queries are the default and ordered properly in history 

    Error: expect(received).toEqual(expected) // deep equality

    - Expected  - 2
    + Received  + 2

      Array [
    -   "from 'sample.tsv' | 3 now",
    -   "from 'sample.tsv' | 2 now",
    +   "from 'sample.tsv' | 123 now",
    +   "from 'sample.tsv' | 12 now",
        "from 'sample.tsv' | 1 now",
      ]

      31 |       "from 'sample.tsv' | 1 now",
      32 |     ];
    > 33 |     expect(entries).toEqual(expected);
         |                     ^
      34 |   });
      35 |
      36 |   test("named queries' creation, modification, update/save, proper outdated status display", async () => {

        at /home/runner/work/zui/zui/packages/e2e-tests/tests/queries.spec.ts:33:21
        at runMicrotasks (<anonymous>)

However, they ran fine when I ran them locally on my Macbook. After reproducing it locally on Linux I could see that the problem was because the test was hard-wired to do a "select all" key combination in the editor that would only work on macOS. Since that combo wasn't working on Linux where the CI runs in Actions, the tests kept appending to whatever was already in the editor.

https://github.com/brimdata/zui/actions/runs/5914897601/job/16040645301 shows the e2e tests now finishing successfully in Actions.

@philrz philrz merged commit 3d3b66d into main Aug 25, 2023
@philrz philrz deleted the e2e-fix-select-all branch August 25, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants