Only use Meta+KeyA combo to Select All on macOS#2842
Merged
Conversation
jameskerr
approved these changes
Aug 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e2e tests recently started showing consistent failures in Actions with this symptom:
However, they ran fine when I ran them locally on my Macbook. After reproducing it locally on Linux I could see that the problem was because the test was hard-wired to do a "select all" key combination in the editor that would only work on macOS. Since that combo wasn't working on Linux where the CI runs in Actions, the tests kept appending to whatever was already in the editor.
https://github.com/brimdata/zui/actions/runs/5914897601/job/16040645301 shows the e2e tests now finishing successfully in Actions.