Conversation
This fixes the following two e2e failures, which I often see.
$ yarn e2e pool-loads:17 pool-loads:26 --reporter=line
Running 2 tests using 1 worker
1) pool-loads.spec.ts:17:3 › Pool Loads › load data into a pool ==================================
Error: expect(received).toEqual(expected) // deep equality
- Expected - 4
+ Received + 1
- Array [
- "count",
- "1",
- ]
+ Array []
20 | await app.query("count()")
21 | const results = await app.getViewerResults()
> 22 | expect(results).toEqual(["count", "1"])
| ^
23 | await app.mainWin.getByText("Load Successful").waitFor({state: "hidden"})
24 | })
25 |
at /Users/noah/brimdata/brim/packages/e2e-tests/tests/pool-loads.spec.ts:22:21
2) pool-loads.spec.ts:26:3 › Pool Loads › load more data into the pool ===========================
Error: expect(received).toEqual(expected) // deep equality
- Expected - 4
+ Received + 1
- Array [
- "count",
- "2",
- ]
+ Array []
34 | await app.query("count()")
35 | const results = await app.getViewerResults()
> 36 | expect(results).toEqual(["count", "2"])
| ^
37 | await app.mainWin.getByText("Load Successful").waitFor({state: "hidden"})
38 | })
39 |
at /Users/noah/brimdata/brim/packages/e2e-tests/tests/pool-loads.spec.ts:36:21
2 failed
pool-loads.spec.ts:17:3 › Pool Loads › load data into a pool ===================================
pool-loads.spec.ts:26:3 › Pool Loads › load more data into the pool ============================
philrz
reviewed
Mar 1, 2023
Contributor
philrz
left a comment
philrz
left a comment
There was a problem hiding this comment.
It runs reliably for me in the branch. I've got high hopes this'll make it run reliably in Actions as well. 🤞
I also wanted to point out the comment a few lines up:
I'm not sure if more needs to be done beyond what's in this PR to meet the full definition of "wait for the cells to populate", but I'm guessing that comment should either now be removed or updated to estimate what more is left to be done.
jameskerr
approved these changes
Mar 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following two e2e failures, which I often see.