Enable assisted installer so per-machine can be selected#2686
Conversation
|
This morning I also used my personal fork to confirm that this plays nicely with auto-update, and the tests were successful. A summary:
|
2 participants
{{ message }}
Merged
Closed
Closed
Contributor
Author
This was referenced Mar 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.electron.build/configuration/nsis describes the options being used here. Up until now we've always gone with the electron-builder default of a one-click, per-user install. With the combination I'm using in this PR, the user will be prompted as shown in the following video (made with a Dev build from this Actions run), such that they can choose the per-machine install. After selecting that install option I logged out and logged in as a different user and confirmed I saw the Zui icon on its desktop and could launch the app ok. The app binaries in that case end up in
%ProgramFiles%\Zui(i.e.,C:\Program Files\Zui) rather than the%USERPROFILE%\AppData\Local\Programs\Zuithat we're accustomed to seeing with the per-user install.Test.mp4
Since Zui Insiders derives its electron-builder config from Zui, I also made a Dev build in this Actions run and confirmed that also worked fine with per-machine install.
If this merges, I'll update the docs in #2531 to mention this as an alternate install option and filesystem path.
For #2685