Merged
Conversation
jameskerr
approved these changes
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2459 (comment) has detailed background.
tl;dr - By changing the
appId, now when Windows and macOS users of Brim v0.31.0 auto-update or manually install Zui v1.0, their Brim install will not disappear from their list of installed Programs/Applications and hence will need to be manually uninstalled. The benefit of this is that on Windows all users will have Application Binaries directories with "zui" in the path and hence tools like ones planned for Zed lake migration can find tine CLI tools in the expected location.Closes #2459