Merged
Conversation
nwt
force-pushed
the
fix-ingest-warnings
branch
from
3d77acc to
618abc9
Compare
We were sending the action back to the sender. We were not marking an action as remote. We were not checking if an action was remote.
jameskerr
approved these changes
Feb 7, 2023
Contributor
jameskerr
left a comment
jameskerr
left a comment
There was a problem hiding this comment.
One spelling error, then good to merge.
Co-authored-by: James Kerr <[email protected]>
Contributor
|
It's definitely a huge improvement that the warnings are now visible to the user, so I'd absolutely take this fix as is. That said, given that "load" and "ingest" are roughly synonymous, it feels strange that the messages "Ingest failed with warnings" and "Load successful" appear on the screen at the same time. If it were possible in this case to change the "Load successful" to something that reflects the load only partially succeeded, that would help a lot, I think. |
Member
Author
|
@philrz: I agree, but that "Load successful" toast comes from code I'm not touching here, and the way to make the change you suggest isn't obvious to me, so I think that's fodder for another PR. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ingest warnings have been broken for a while. Fix them.
Included are fixes to some global dispatcher bugs that were causing the Pools.appendWarning reducer to run three times per dispatch.
The video below shows what ingest warnings look like now.
Screen.Recording.2023-02-07.at.12.01.19.PM.mov
Closes #2554
Closes #2606