Watch for "Load Successful" pop-up after pool creation#2600
Merged
Conversation
jameskerr
reviewed
Nov 28, 2022
jameskerr
approved these changes
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying my hand at creating an e2e test by going off some existing tests and I was getting unexpected results. It turns out the example I was following may have had problems, as I found that if I replaced the
Import Complete.in this diff with garbage text, the test still passed without complaint. I looked for other examples and found that changing toexpect(...).toBeVisible()did what I think was intended, as now it chokes on garbage text but runs successfully when it sees theLoad Successfulpop-up. However, one snag remained in that the linter complainederror: Expect must be inside of a test block. I figured out how to adjust the linter rules to allow this, but if there's a better way to go about this, I'm all ears.