Skip to content

Watch for "Load Successful" pop-up after pool creation#2600

Merged
philrz merged 3 commits intomainfrom
createpool-check-success
Nov 29, 2022
Merged

Watch for "Load Successful" pop-up after pool creation#2600
philrz merged 3 commits intomainfrom
createpool-check-success

Conversation

@philrz
Copy link
Contributor

@philrz philrz commented Nov 27, 2022

I was trying my hand at creating an e2e test by going off some existing tests and I was getting unexpected results. It turns out the example I was following may have had problems, as I found that if I replaced the Import Complete. in this diff with garbage text, the test still passed without complaint. I looked for other examples and found that changing to expect(...).toBeVisible() did what I think was intended, as now it chokes on garbage text but runs successfully when it sees the Load Successful pop-up. However, one snag remained in that the linter complained error: Expect must be inside of a test block. I figured out how to adjust the linter rules to allow this, but if there's a better way to go about this, I'm all ears.

@philrz philrz requested a review from jameskerr November 27, 2022 00:12
@philrz philrz self-assigned this Nov 27, 2022
@philrz philrz requested a review from jameskerr November 28, 2022 22:31
@philrz philrz merged commit 0a07e2a into main Nov 29, 2022
@philrz philrz deleted the createpool-check-success branch November 29, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants