Skip to content

Add ZSON export option#2509

Merged
philrz merged 1 commit intomainfrom
export-zson
Aug 31, 2022
Merged

Add ZSON export option#2509
philrz merged 1 commit intomainfrom
export-zson

Conversation

@philrz
Copy link
Contributor

@philrz philrz commented Aug 30, 2022

I followed the Export fix & test PRs closely enough that I could see that adding this ZSON export feature might not be too hard. Indeed, it took just a few lines of code to make it work and add a test that passes.

Demo.mp4
$ yarn e2e

Running 14 tests using 1 worker

  ✓  export.spec.ts:36:5 › Export tests › Exporting in zng format succeeds (1s)
  ✓  …rt.spec.ts:36:5 › Export tests › Exporting in zson format succeeds (901ms)
  ✓  …rt.spec.ts:36:5 › Export tests › Exporting in json format succeeds (899ms)
...

Closes #1486

@philrz philrz requested a review from jameskerr August 30, 2022 22:22
@philrz philrz self-assigned this Aug 30, 2022
Copy link
Contributor

@jameskerr jameskerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yeah!

@jameskerr
Copy link
Contributor

What's that trick you do in the file explorer to type the path?

@philrz
Copy link
Contributor Author

philrz commented Aug 31, 2022

@jameskerr: Cmd-Shift-G brings up the prompt to type a path. It's something I picked up early in my Mac days and now it's this weird muscle memory I don't even think about. 🤪

@philrz philrz merged commit 817a299 into main Aug 31, 2022
@philrz philrz deleted the export-zson branch August 31, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZSON export

2 participants