Merged
Conversation
mason-fish
approved these changes
May 19, 2021
Contributor
mason-fish
left a comment
mason-fish
left a comment
There was a problem hiding this comment.
lgtm! I pulled it down to click around and it seems very solid 👍 Just left a couple comments (I think my global state comment is the only one of significance)
app/release-notes/release-notes.tsx
Outdated
|
|
||
| return ( | ||
| <Scrollable> | ||
| <BG className="release-notes"> |
Contributor
There was a problem hiding this comment.
I can't find where you're using this class (and am hoping that it is simply unused so that all of this component's styling is in one place 😬 ). Do we need it?
Contributor
Author
There was a problem hiding this comment.
Nope, that was used when I was developing, but it's not needed anymore. Thanks!
| import Launches from "./Launches" | ||
|
|
||
| export default combineReducers<any, any>({ | ||
| launches: Launches.reducer, |
Contributor
There was a problem hiding this comment.
I think you'll also want to add this to the global reducer, no?
| "jwt-decode": "^3.1.2", | ||
| "keytar": "^7.3.0", | ||
| "lodash": "^4.17.19", | ||
| "markdown-it": "^10.0.0", |
Contributor
There was a problem hiding this comment.
Oh nice, I forgot we even had this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1594
Follows the spec described in the issue. Here are some screenshots.