zqd: Prevent orphaned zqd (unix)#1031
Merged
alfred-landrum merged 2 commits intomasterfrom Sep 3, 2020
Merged
Conversation
mattnibs
force-pushed
the
orphaned-zqd
branch
2 times, most recently
from
0a7bff8 to
c6ebcb8
Compare
Contributor
Author
|
zqd changes here: brimdata/super#1184 |
mattnibs
force-pushed
the
orphaned-zqd
branch
4 times, most recently
from
1244bcd to
751e431
Compare
Prevent orphaned zqd when Brim exits with SIGKILL. If platform is not windows, create posix pipe and pass read fd to zqd via the -brimfd argument. Should brim be closed with SIGKILL the fd will be closed and zqd, seeing the fd has closed will exit. Closes #1018
mattnibs
commented
Aug 31, 2020
jameskerr
reviewed
Aug 31, 2020
| if (process.platform !== "win32") { | ||
| const {readfd} = require("node-pipe").pipeSync() | ||
| opts.stdio.push(readfd) | ||
| args.push(`-brimfd=${opts.stdio.length - 1}`) |
Contributor
There was a problem hiding this comment.
I'm not sure how this works so I may be off, but it looks like you'll pass in the integer 3 here. Were you intending to access the array opts.stdio[opts.stdio.length - 1]?
jameskerr
approved these changes
Sep 3, 2020
Contributor
jameskerr
left a comment
jameskerr
left a comment
There was a problem hiding this comment.
This works when I tested it out on my machine.
Contributor
|
Merging for @mattnibs who's out at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent orphaned zqd when Brim exits with SIGKILL.
If platform is not windows, create posix pipe and pass read fd
to zqd via the -brimfd argument. Should brim be closed with SIGKILL
the fd will be closed and zqd, seeing the fd has closed will exit.
Closes #1018