Crash when accessing remote lake (broke at 2473666) #3100
Description
Repro is with Zui commit 2473666.
In the attached video, I click Add Lake in an attempt to connect to a remote lake, specifically the one behind my Zui Insiders at http://localhost:9988. As the video shows, this results in a crash and a failure to access the lake.
Repro.mp4
The complete error dump:
Unhandled Runtime Error
Error: <!DOCTYPE html><html><head><style data-next-hide-fouc="true">body{display:none}</style><noscript data-next-hide-fouc="true"><style>body{display:block}</style></noscript><meta charSet="utf-8"/><meta name="viewport" content="width=device-width"/><title>404: This page could not be found</title><meta name="next-head-count" content="3"/><noscript data-n-css=""></noscript><script defer="" nomodule="" src="/_next/static/chunks/polyfills.js?ts=1718733506065"></script><script src="/_next/static/chunks/webpack.js?ts=1718733506065" defer=""></script><script src="/_next/static/chunks/main.js?ts=1718733506065" defer=""></script><script src="/_next/static/chunks/pages/_app.js?ts=1718733506065" defer=""></script><script src="/_next/static/chunks/pages/_error.js?ts=1718733506065" defer=""></script><script src="/_next/static/development/_buildManifest.js?ts=1718733506065" defer=""></script><script src="/_next/static/development/_ssgManifest.js?ts=1718733506065" defer=""></script><noscript id="__next_css__DO_NOT_USE__"></noscript></head><body><div id="__next"><div style="font-family:system-ui,"Segoe UI",Roboto,Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";height:100vh;text-align:center;display:flex;flex-direction:column;align-items:center;justify-content:center"><div><style>body{color:#000;background:#fff;margin:0}.next-error-h1{border-right:1px solid rgba(0,0,0,.3)}@media (prefers-color-scheme:dark){body{color:#fff;background:#000}.next-error-h1{border-right:1px solid rgba(255,255,255,.3)}}</style><h1 class="next-error-h1" style="display:inline-block;margin:0 20px 0 0;padding-right:23px;font-size:24px;font-weight:500;vertical-align:top;line-height:49px">404<!-- --></h1><div style="display:inline-block;text-align:left"><h2 style="font-size:14px;font-weight:400;line-height:49px;margin:0">This page could not be found<!-- -->.<!-- --></h2></div></div></div></div><script src="/_next/static/chunks/react-refresh.js?ts=1718733506065"></script><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{"statusCode":404}},"page":"/_error","query":{"ctrl":"true"},"buildId":"development","isFallback":false,"gip":true,"scriptLoader":[]}</script></body></html>
Source
../packages/zed-js/src/util/error.ts (15:30) @ createError
13 | return e;
14 | }
> 15 | if (isString(input)) return new Error(input);
| ^
16 |
17 | return new Error('Unknown Error');
18 | }
Call Stack
Client.send
../packages/zed-js/src/client/base-client.ts (190:40)
async Client.query
../packages/zed-js/src/client/base-client.ts (41:19)
async Client.getPools
../packages/zed-js/src/client/base-client.ts (99:17)
This crash started occurring at this commit 2473666, which is associated with the changes in #3096.