Skip to content

"brimcap -version" on bundled binary shows "-dirty" #2840

@philrz

Description

@philrz

Repro is with Zui commit cb746af.

While investigating #2839, I discovered that there's also been problems with the -version output of the brimcap binary that's bundled with Zui. In terms of GA releases, I confirmed that this started happening at GA Zui tagged v1.0.1 and has been with us since. Looking at individual commits I can see that's also the exact spot where it began.

$ for COMMIT in 76707da cb746af; do   rm -rf ~/.yarn/berry/cache/brimcap* && git clone https://github.com/brimdata/zui.git zui-${COMMIT} && pushd zui-${COMMIT} && git checkout ${COMMIT} && yarn && node_modules/brimcap/build/dist/brimcap -version; popd; done
...
Note: switching to '76707da'.
...
Version: v1.4.0-7-g41f21af
...
Note: switching to 'cb746af'.
...
Version: v1.4.1-dirty

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions