Skip to content

No error message displayed on CSV load exception #2606

@philrz

Description

@philrz

Repro is with Brim commit 96a0951 which uses Zed commit 22f640e. This issue feels very similar to the existing JSON-related one in #2554.

A community zync user reported a problem reading CSV with Zui. In their own words:

Zui did not report any problem. It just stopped the CSV import without any message at all. I noticed because I compared count() to the wc.
maybe simply send a more comprehensive error message in Zed/Zui when CSV import fails before the EOF? line number and column number with last value parsed?

Indeed, as shown in the following video, reading the file bad.csv using CLI tooling does show an error, but the app just shows the data that parsed ok without any mention of the error. This is a data correctness hazard since it gives the user the impression they're working with all their data when it's actually truncated.

Repro.mp4

As we can see in Wireshark, the error message was returned from the backend, but just didn't make it all the way to the user.

image

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions