Skip to content

"Find" within window contents (similar to Cmd/Ctrl+F on Chrome) #2574

@philrz

Description

@philrz

Repro is with Brim commit ab5b75d.

In the attached video, I'm working with the saved query from ciphers.json.gz which contains a const map definition that's over 15k characters wide. I needed to find where an element containing specific text was located and had to cut & paste the editor window's contents into a separate non-Brim editor so i could locate it. As users' Zed programs become more sophisticated these kinds of struggles are likely to come up more often.

Repro.mp4

What I'd have done in this kind of situation in a browser context is invoke the "Find" tool, such as is invoked via Cmd/Ctrl+F in Chrome. Indeed, since Electron shares a lot of its base with Chrome I'd hoped that maybe it was something that could be trivially enabled, but a quick web search revealed an old issue electron/electron#2037 where a spokesperson claimed that's not supported out-of-the-box in Electron. Thankfully as the thread continues people speak as if the API has made it increasingly simple and it looks like there's implementations out there we could borrow from.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions