Add positional information to semantic errors#5121
Merged
Conversation
mattnibs
force-pushed
the
positional-sem-errors
branch
2 times, most recently
from
fe5477a to
ee91cb3
Compare
mattnibs
force-pushed
the
positional-sem-errors
branch
from
ee91cb3 to
789ddf2
Compare
nwt
reviewed
May 31, 2024
nwt
force-pushed
the
positional-sem-errors
branch
2 times, most recently
from
e8f887c to
0adda42
Compare
mattnibs
force-pushed
the
positional-sem-errors
branch
from
0adda42 to
df5e345
Compare
mattnibs
force-pushed
the
positional-sem-errors
branch
from
df5e345 to
6a7a54b
Compare
This commit changes errors produced from semantic analysis so they include a reference to the AST node which produced the error. The allows for highlighting the specific portion of the source that caused a semantic error. This commit also changes how semantic errors are collected in that the semantic analyzer no longer exits as soon as the first error is found and instead goes on the analyze the rest of the AST, reporting all semantic errors in the AST.
mattnibs
force-pushed
the
positional-sem-errors
branch
from
6a7a54b to
280ebf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes errors produced from semantic analysis so they include a reference to the AST node which produced the error. The allows for highlighting the specific portion of the source that caused a semantic error.
This commit also changes how semantic errors are collected in that the semantic analyzer no longer exits as soon as the first error is found and instead goes on the analyze the rest of the AST, reporting all semantic errors in the AST.