Add ability to run manage from the serve command#5017
Merged
Conversation
mattnibs
force-pushed
the
serve-manage
branch
2 times, most recently
from
c310689 to
9e60962
Compare
nwt
reviewed
Feb 1, 2024
This commit adds the ability to run zed manage in the same process as the zed serve command. If the -manage flag is set with a duration greater than 0 manage will run. This commit also move the manage package to lake/api/manage package and simplifies the logic for the monitor function.
mattnibs
force-pushed
the
serve-manage
branch
from
9e60962 to
dad9f45
Compare
nwt
reviewed
Feb 6, 2024
Collaborator
Author
Agreed. |
Co-authored-by: Noah Treuhaft <[email protected]>
Contributor
|
I just tested this branch out at commit 9ce0f4f and it seems to work fine. One thing I found a little odd though is that I went looking for a ztest in this PR since that usually gives me a starting point for seeing how the new functionality is invoked and it looks like the only ztest change is to something that only exercises the pre-existing approach that used the |
Collaborator
Author
|
@philrz yes |
nwt
approved these changes
Feb 7, 2024
Contributor
This was referenced Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to run zed manage in the same process as the zed serve command. If the -manage flag is set with a duration greater than 0 manage will run.
This commit also move the manage package to lake/api/manage package and simplifies the logic for the monitor function.