Conversation
Both formats require a seekable reader so this only works with files and URIs that are not gzip-compressed. It does not work with standard input, fifos, or gzip-compressed data. Closes #2517.
mccanne
reviewed
Dec 15, 2022
zio/anyio/reader.go
Outdated
| parquetErr = fmt.Errorf("parquet: %w", parquetErr) | ||
| vngErr = fmt.Errorf("vng: %w", vngErr) | ||
| } else { | ||
| parquetErr = errors.New("parquet: reader cannot seek") |
Collaborator
There was a problem hiding this comment.
"reader cannot seek" is describing the implementation not the supported types of inputs begging the question "what's a reader?". How about seekable input required for auto-detection (consider "-i parquet")
Member
Author
There was a problem hiding this comment.
@mccanne: Good point, though "consider '-i parquet'" isn't quite the right advice since that won't make the input seekable, and that's the requirement here. I'll go with "seekable input required for auto-detection" unless you've got other ideas.
Member
Author
There was a problem hiding this comment.
Done in f82fb69, though the exact language I used is "auto-detection requires seekable input" to align with lineErr := errors.New("line: auto-detection not supported").
mattnibs
approved these changes
Dec 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both formats require a seekable reader so this only works with files and URIs that are not gzip-compressed. It does not work with standard input, fifos, or gzip-compressed data.
Closes #2517.