Conversation
mattnibs
force-pushed
the
brimfd
branch
3 times, most recently
from
8518fd8 to
9d2bfd9
Compare
Add hidden -brimfd flag to zqd listen. Brim will use this option to prevent zqd from being orphaned in the event that Brim is terminated with a SIGKILL signal. If set zqd with listen to the file descriptor and gracefully should it be closed. PART OF brimdata/zui#1018
Contributor
alfred-landrum
left a comment
alfred-landrum
left a comment
There was a problem hiding this comment.
My comments are all just minor name changes, looks good to me overall. Like we discussed live, this seemed like the least invasive way to ensure zqd shuts down.
alfred-landrum
approved these changes
Aug 27, 2020
Co-authored-by: Alfred Landrum <[email protected]>
brim-bot
pushed a commit
to brimdata/zui
that referenced
this pull request
Aug 27, 2020
…y mattnibs This is an auto-generated commit with a zq dependency update. The zq PR brimdata/super#1184, authored by @mattnibs, has been merged. zqd: prevent being orphaned by Brim (unix only) Add hidden -brimfd flag to zqd listen. Brim will use this option to prevent zqd from being orphaned in the event that Brim is terminated with a SIGKILL signal. If set zqd with listen to the file descriptor and gracefully should it be closed. PART OF #1018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add hidden -brimfd flag to zqd listen. Brim will use this option
to prevent zqd from being orphaned in the event that Brim is terminated
with a SIGKILL signal.
If set zqd with listen to the file descriptor and gracefully should
it be closed.
PART OF brimdata/zui#1018