Pass additional command line args to suricataupdater.exe#63
Merged
Conversation
nwt
reviewed
Jul 13, 2022
philrz
commented
Jul 15, 2022
| "--no-test", | ||
| "--no-reload") | ||
| "--no-reload", | ||
| }, os.Args[1:]...) |
Contributor
Author
There was a problem hiding this comment.
@nwt: Thanks for the suggestions to tighten this up. I had to make a couple final adjustments while incorporating in order to get it to compile and test successfully.
This first change of adding the [1:] was necessary because the 0th element of os.Args[] is the invoked command and that needed to be skipped.
| "--no-reload") | ||
| "--no-reload", | ||
| }, os.Args[1:]...) | ||
| cmd := exec.Command(execPath, args...) |
Contributor
Author
There was a problem hiding this comment.
@nwt: This second change of adding the ... was necessary because without it:
main.go:48:21: cannot use args (type []string) as type string in argument to exec.Command
nwt
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shell-based
suricataupdaterwrappers pass along"$@"tosuricata-update, which allows for additional args such as to load local rules. However, a community user pointed out via brimdata/brimcap#259 that the Go-basedsuricataupdate.exewe provide for Windows doesn't do the equivalent. The changes here address that. The user that opened brimdata/brimcap#259 has already confirmed that an executable based on those changes is doing what's needed in their environment.Fixes brimdata/brimcap#259