Add additional character to GBFormatter alphaIn#9
Merged
BenMorel merged 2 commits intobrick:masterfrom Jul 10, 2022
morphsites-limited:master
Merged
Add additional character to GBFormatter alphaIn#9BenMorel merged 2 commits intobrick:masterfrom morphsites-limited:master
BenMorel merged 2 commits intobrick:masterfrom
morphsites-limited:master
Conversation
Member
|
Hi, thank you for your PR! Please add a test here and I'll merge it. |
Contributor
Author
|
@BenMorel Hopefully I've done as requested, tests now pass instead of failing where they were testing agains C being in the inwards code. |
Member
|
Thank you, just one thing: can the |
Contributor
Author
|
@BenMorel I believe the C can be in any position in the inward code |
Member
|
Thank you! Released as 0.2.7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for postcodes ending in a C such as TQ12 6QC which is a valid postcode: https://www.devon.gov.uk/communities/assets/stover-country-park