build: Default to clang-cl and have cc-rs find it, on aarch64-pc-windows-msvc.#2803
Merged
briansmith merged 2 commits intomainfrom Mar 16, 2026
Merged
build: Default to clang-cl and have cc-rs find it, on aarch64-pc-windows-msvc.#2803briansmith merged 2 commits intomainfrom
briansmith merged 2 commits intomainfrom
Conversation
…ows-msvc. Don't require "clang" to be in the path for AArch64 Windows builds. Use clang-cl, which has an MSVC cl.exe style command line, so that CFLAGS and other settings are picked up automatically. Inspired by Dennis Ameling's PR.
briansmith
force-pushed
the
b/prefer-clang-over-msvc
branch
from
a97c679 to
188db95
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2803 +/- ##
=======================================
Coverage 96.71% 96.71%
=======================================
Files 204 204
Lines 20353 20353
Branches 519 519
=======================================
Hits 19684 19684
Misses 552 552
Partials 117 117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can you please consider making a patch release with this? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't require "clang" to be in the path for AArch64 Windows builds. Use clang-cl, which has an MSVC cl.exe style command line, so that CFLAGS and other settings are picked up automatically.
Inspired by Dennis Ameling's PR.