Skip to content
This repository was archived by the owner on Dec 9, 2018. It is now read-only.
This repository was archived by the owner on Dec 9, 2018. It is now read-only.

Error compiling when using v8 3.29 #144

@waTeim

Description

@waTeim

Hi all, I'm working on combining atom-shell, Julia, and d3 to be used as a data visualizer. D3 needs contextify, but the problem is that the released versions of node use a earlier version of v8.

node 0.10.35:    3.14.5.9
node 0.11.13:    3.25.30
node 0.11.14:    3.26.33
atom-shell:      3.29.88.17

In v8 3.29, the function ContextDisposedNotification is no longer a static member function of the class V8, but rather a member function of v8::Isolate, and so contextify.cc will not compile

 CXX(target) Release/obj.target/contextify/src/contextify.o
../src/contextify.cc:31:13: error: no member named 'ContextDisposedNotification' in namespace 'v8'

Luckily atom-shell provides sufficient defines to conditionally compile

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions