Add ability to opt-in to int8 parsing#427
Merged
Merged
Conversation
Switching the result of all COUNT operations to a string is a pretty nasty breaking change, and the majority of us aren't going to be hitting numbers larger than Number.MAX_VALUE
brianc
added a commit
that referenced
this pull request
Aug 29, 2013
Add ability to opt-in to int8 parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching the result of all COUNT operations to a string is
a pretty nasty breaking change, and the majority of us aren't
going to be hitting numbers larger than Number.MAX_VALUE
I bumped the major version number, but this makes the upgrade easier. I know in my apps I don't ever use 64bit numbers but I do COUNT(*) all over the place.
fixes #378
to opt in just do
Basically this is a handy shortcut for this: