[fix] fix unhandled callback error for submittables (#3589)

uap-dev · charmander · web-flow · commit 46cdf9e32b70 · 2026-02-02T20:19:30.000-06:00
* fixes bug where submittable without callback throws error

* add querystream to test remove comments

* fix test

* Revert unrelated reformatting

---------

Co-authored-by: Charmander &lt;~@charmander.me&gt;
diff --git a/packages/pg-query-stream/test/error.ts b/packages/pg-query-stream/test/error.ts
@@ -170,4 +170,24 @@ describe('error recovery', () => {
     conn.release()
     await pool.end()
   })
+
+  it('does not crash when query_timeout fires without callback', async () => {
+    const client = new Client({ query_timeout: 50 })
+    await client.connect()
+
+    const stream = new QueryStream('SELECT pg_sleep(10)')
+
+    // cursor.on('error') fires synchronously when handleError is called
+    // stream.on('error') fires asynchronously via destroy()
+    // Use cursor for immediate error detection
+    const errorPromise = new Promise<Error>((resolve) => {
+      stream.cursor.on('error', resolve)
+    })
+
+    client.query(stream)
+
+    const error = await errorPromise
+    assert.equal(error.message, 'Query read timeout')
+    await client.end()
+  })
 })
diff --git a/packages/pg/lib/client.js b/packages/pg/lib/client.js
@@ -628,7 +628,7 @@ class Client extends EventEmitter {
     }
 
     if (readTimeout) {
-      queryCallback = query.callback
+      queryCallback = query.callback || (() => {})
 
       readTimeoutTimer = setTimeout(() => {
         const error = new Error('Query read timeout')
diff --git a/packages/pg/lib/native/client.js b/packages/pg/lib/native/client.js
@@ -184,7 +184,7 @@ Client.prototype.query = function (config, values, callback) {
   }
 
   if (readTimeout) {
-    queryCallback = query.callback
+    queryCallback = query.callback || (() => {})
 
     readTimeoutTimer = setTimeout(() => {
       const error = new Error('Query read timeout')
diff --git a/packages/pg/test/unit/client/query-timeout-tests.js b/packages/pg/test/unit/client/query-timeout-tests.js
@@ -0,0 +1,34 @@
+'use strict'
+
+const helper = require('./test-helper')
+const Query = require('../../../lib/query')
+const assert = require('assert')
+const suite = new helper.Suite()
+const test = suite.test.bind(suite)
+
+test('query timeout with Submittable without callback delivers error via handleError', function (done) {
+  const client = helper.client()
+  client.connectionParameters = { query_timeout: 10 }
+
+  const query = new Query({ text: 'SELECT 1' })
+  query.handleError = (err) => {
+    assert.equal(err.message, 'Query read timeout')
+    done()
+  }
+
+  client.connection.emit('readyForQuery')
+  client.query(query)
+})
+
+test('query timeout with Submittable with callback delivers error via callback', function (done) {
+  const client = helper.client()
+  client.connectionParameters = { query_timeout: 10 }
+
+  const query = new Query({ text: 'SELECT 1' })
+  client.connection.emit('readyForQuery')
+
+  client.query(query, (err) => {
+    assert.equal(err.message, 'Query read timeout')
+    done()
+  })
+})

Original file line number	Diff line number	Diff line change
`@@ -628,7 +628,7 @@ class Client extends EventEmitter {`
`628`	`628`	`}`
`629`	`629`
`630`	`630`	`if (readTimeout) {`
`631`		`- queryCallback = query.callback`
	`631`	`+ queryCallback = query.callback \|\| (() => {})`
`632`	`632`
`633`	`633`	`readTimeoutTimer = setTimeout(() => {`
`634`	`634`	`const error = new Error('Query read timeout')`
Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ Client.prototype.query = function (config, values, callback) {`
`184`	`184`	`}`
`185`	`185`
`186`	`186`	`if (readTimeout) {`
`187`		`- queryCallback = query.callback`
	`187`	`+ queryCallback = query.callback \|\| (() => {})`
`188`	`188`
`189`	`189`	`readTimeoutTimer = setTimeout(() => {`
`190`	`190`	`const error = new Error('Query read timeout')`