Repository navigation
Commit 329ef26
committed
fix: avoid lost-wakeup hang in get_equality_delete_predicate_for_delete_file_path
The equality-delete loader signals completion with Notify::notify_waiters(),
which stores no permit and only wakes Notified futures created before the call.
get_equality_delete_predicate_for_delete_file_path observed the Loading state,
released the read lock, and only then created the Notified future; a
notify_waiters() fired in that window is lost and the await hangs forever.
Create the Notified (via notified_owned) while still holding the read lock, so
it is guaranteed to precede any notify_waiters() and be delivered.
Signed-off-by: Dhruv Arya <[email protected]>1 parent e8460ee commit 329ef26
1 file changed
Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
166 | | - | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
167 | 172 | | |
168 | 173 | | |
169 | | - | |
| 174 | + | |
170 | 175 | | |
171 | 176 | | |
172 | 177 | | |
173 | 178 | | |
174 | 179 | | |
175 | 180 | | |
176 | | - | |
| 181 | + | |
177 | 182 | | |
178 | 183 | | |
179 | 184 | | |
| |||
0 commit comments