Check closed condition before attempting to set network timeout.

brettwooldridge · brettwooldridge · commit 88b57c3bd7cd · 2018-05-20T13:38:24.000+09:00
diff --git a/src/main/java/com/zaxxer/hikari/pool/PoolBase.java b/src/main/java/com/zaxxer/hikari/pool/PoolBase.java
@@ -128,9 +128,10 @@ void quietlyCloseConnection(final Connection connection, final String closureRea
          try {
             LOGGER.debug("{} - Closing connection {}: {}", poolName, connection, closureReason);
             try {
-               setNetworkTimeout(connection, SECONDS.toMillis(15));
-            }
-            finally {
+               if (!connection.isClosed()) {
+                  setNetworkTimeout(connection, SECONDS.toMillis(15));
+               }
+            } finally {
                connection.close(); // continue with the close even if setNetworkTimeout() throws
             }
          }

Original file line number	Diff line number	Diff line change
`@@ -128,9 +128,10 @@ void quietlyCloseConnection(final Connection connection, final String closureRea`
`128`	`128`	`try {`
`129`	`129`	`LOGGER.debug("{} - Closing connection {}: {}", poolName, connection, closureReason);`
`130`	`130`	`try {`
`131`		`- setNetworkTimeout(connection, SECONDS.toMillis(15));`
`132`		`- }`
`133`		`- finally {`
	`131`	`+ if (!connection.isClosed()) {`
	`132`	`+ setNetworkTimeout(connection, SECONDS.toMillis(15));`
	`133`	`+ }`
	`134`	`+ } finally {`
`134`	`135`	`connection.close(); // continue with the close even if setNetworkTimeout() throws`
`135`	`136`	`}`
`136`	`137`	`}`