Update validation failure message.

brettwooldridge · brettwooldridge · commit 6a139803127b · 2018-05-19T18:42:36.000+09:00
diff --git a/src/main/java/com/zaxxer/hikari/pool/PoolBase.java b/src/main/java/com/zaxxer/hikari/pool/PoolBase.java
@@ -54,7 +54,7 @@ abstract class PoolBase
    private final Logger LOGGER = LoggerFactory.getLogger(PoolBase.class);
 
    public final HikariConfig config;
-   public IMetricsTrackerDelegate metricsTracker;
+   IMetricsTrackerDelegate metricsTracker;
 
    protected volatile String catalog;
    protected final String poolName;
@@ -172,7 +172,8 @@ boolean isConnectionAlive(final Connection connection)
       }
       catch (Exception e) {
          lastConnectionFailure.set(e);
-         LOGGER.warn("{} - Failed to validate connection {} ({})", poolName, connection, e.getMessage());
+         LOGGER.warn("{} - Failed to validate connection {} ({}). Possibly consider using a shorter maxLifetime value.",
+                     poolName, connection, e.getMessage());
          return false;
       }
    }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ abstract class PoolBase`
`54`	`54`	`private final Logger LOGGER = LoggerFactory.getLogger(PoolBase.class);`
`55`	`55`
`56`	`56`	`public final HikariConfig config;`
`57`		`- public IMetricsTrackerDelegate metricsTracker;`
	`57`	`+ IMetricsTrackerDelegate metricsTracker;`
`58`	`58`
`59`	`59`	`protected volatile String catalog;`
`60`	`60`	`protected final String poolName;`
`@@ -172,7 +172,8 @@ boolean isConnectionAlive(final Connection connection)`
`172`	`172`	`}`
`173`	`173`	`catch (Exception e) {`
`174`	`174`	`lastConnectionFailure.set(e);`
`175`		`- LOGGER.warn("{} - Failed to validate connection {} ({})", poolName, connection, e.getMessage());`
	`175`	`+ LOGGER.warn("{} - Failed to validate connection {} ({}). Possibly consider using a shorter maxLifetime value.",`
	`176`	`+ poolName, connection, e.getMessage());`
`176`	`177`	`return false;`
`177`	`178`	`}`
`178`	`179`	`}`