This repository was archived by the owner on Jul 31, 2020. It is now read-only.
Introduce device id v2 - #362
Merged
Merged
Conversation
darkdh
force-pushed
the
dup-device-id
branch
3 times, most recently
from
December 9, 2019 04:09
109cdd6 to
275c5f2
Compare
fix test add comments
darkdh
force-pushed
the
dup-device-id
branch
from
December 10, 2019 08:55
c83f8fd to
f6a25c1
Compare
darkdh
marked this pull request as ready for review
December 10, 2019 08:55
darkdh
commented
Dec 12, 2019
| return s3Helper.listNotifications( | ||
| this.sqs, notificationParams, category, prefix).then((values) => { | ||
| if (this.shouldRetireOldSQSQueue(parseInt(values.createdTimeStamp))) { | ||
| return this.deleteSQSQueue(this.oldSQSUrlByCat[category]).then(() => { |
Member
Author
There was a problem hiding this comment.
@AlexeyBarabash reminded me that when device id is duplicated, if there is an old Brave which doesn't contain the fix, its SQS queue will be unavailable until next relaunch because upgraded Brave deletes it after 24 hours
Contributor
There was a problem hiding this comment.
I was confused and I thought this.deleteSQSQueue can delete queues belonging to other devices. And like @darkdh mentioned that only can happen if device id was duplicated. Which is a separate case.
Member
Author
There was a problem hiding this comment.
Non upgraded device will get reset anyway, so duplicate case won’t be an issue
Contributor
|
Minor notice All the rest looks good. |
bridiver
approved these changes
Dec 23, 2019
bridiver
added a commit
to brave/brave-core
that referenced
this pull request
Dec 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #333
This PR introduce device id v2 which is a 3 random bytes hex encoded string.
We also keep device id for backward compatibility.
Migration from existing device would be:
SAVE_INIT_DATAfor updating device id v2