Skip to content

Commit 062b32f

Browse files
committed
test(server): await run ingestion milestones without a timeout
1 parent a73a170 commit 062b32f

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

‎apps/server/src/orchestration-v2/RunExecutionService.test.ts‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1618,7 +1618,7 @@ it.effect("ingests new member threads of an owned child after the root turn term
16181618
} as ProviderAdapter.ProviderAdapterV2Event,
16191619
];
16201620

1621-
const observed = yield* Effect.gen(function* () {
1621+
yield* Effect.gen(function* () {
16221622
const runExecution = yield* RunExecutionService.RunExecutionServiceV2;
16231623
yield* runExecution.startRootRun({
16241624
commandId: CommandId.make("command:run-execution-late-child"),
@@ -1669,9 +1669,8 @@ it.effect("ingests new member threads of an owned child after the root turn term
16691669
},
16701670
},
16711671
});
1672-
return yield* Deferred.await(childMessageIngested).pipe(Effect.timeoutOption("2 seconds"));
1672+
yield* Deferred.await(childMessageIngested);
16731673
}).pipe(Effect.provide(layerTest));
1674-
assert.isTrue(Option.isSome(observed), "child message was not ingested after root terminal");
16751674
assert.deepEqual(yield* Ref.get(order), ["root-finalized", "member-thread", "child-message"]);
16761675
// The run's message started the root; the parent agent started the child's turn.
16771676
const recorded = yield* Ref.get(origins);
@@ -2263,7 +2262,7 @@ it.effect(
22632262
nodeId: unrelatedChildNode.id,
22642263
};
22652264

2266-
const closed = yield* Effect.gen(function* () {
2265+
yield* Effect.gen(function* () {
22672266
const runExecution = yield* RunExecutionService.RunExecutionServiceV2;
22682267
yield* runExecution.startRootRun({
22692268
commandId: CommandId.make("command:subagent-interrupt-cascade"),
@@ -2406,9 +2405,8 @@ it.effect(
24062405
},
24072406
},
24082407
});
2409-
return yield* Deferred.await(ingestionDone).pipe(Effect.timeoutOption("2 seconds"));
2408+
yield* Deferred.await(ingestionDone);
24102409
}).pipe(Effect.provide(layerTest));
2411-
assert.isTrue(Option.isSome(closed), "event ingestion fiber did not finish");
24122410

24132411
const events = yield* Ref.get(written);
24142412
const subagentEvents = events.flatMap((event) =>

0 commit comments

Comments
 (0)