Repository navigation
Commit 88b1cf6
committed
fix(cuda.core): repair two regressions in the NVRTC debug source path
Redirecting the NVRTC program name at a temp .cu (NVIDIA#2679) left two problems.
Quoted includes stopped resolving. NVRTC searches the directory of the name it
is handed for #include "...", so moving that name into the temp dir moved the
search with it, and merely enabling debug or lineinfo broke a compile that
worked without it. The directory the name used to denote is now passed back as
--include-path. It is added to the compile options only, never to
ProgramOptions, so the program cache key is unchanged; the cwd was already an
unkeyed input to these compiles before the redirect.
Teardown deleted files it did not create. The name given to NVRTC doubled as
the cleanup target, but that slot still holds the caller's options.name
whenever the source was not redirected, so a name like "matmul.cu" matching a
real file meant close() or collection deleted the caller's own source. The temp
path is tracked separately now and is the only path unlinked.
Removal on close() is left as it was, since NVIDIAgh-2422 asked for it and the tests
added with NVIDIA#2679 assert it.1 parent e85b170 commit 88b1cf6
3 files changed
Lines changed: 77 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
106 | | - | |
107 | | - | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
108 | 112 | | |
109 | 113 | | |
110 | 114 | | |
| |||
852 | 856 | | |
853 | 857 | | |
854 | 858 | | |
| 859 | + | |
855 | 860 | | |
856 | 861 | | |
857 | 862 | | |
| |||
862 | 867 | | |
863 | 868 | | |
864 | 869 | | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
865 | 881 | | |
866 | 882 | | |
867 | 883 | | |
| |||
1035 | 1051 | | |
1036 | 1052 | | |
1037 | 1053 | | |
1038 | | - | |
| 1054 | + | |
1039 | 1055 | | |
1040 | 1056 | | |
1041 | 1057 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1090 | 1090 | | |
1091 | 1091 | | |
1092 | 1092 | | |
| 1093 | + | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
| 1098 | + | |
| 1099 | + | |
| 1100 | + | |
| 1101 | + | |
| 1102 | + | |
| 1103 | + | |
| 1104 | + | |
| 1105 | + | |
| 1106 | + | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
| 1118 | + | |
| 1119 | + | |
| 1120 | + | |
| 1121 | + | |
| 1122 | + | |
| 1123 | + | |
| 1124 | + | |
| 1125 | + | |
| 1126 | + | |
| 1127 | + | |
| 1128 | + | |
| 1129 | + | |
| 1130 | + | |
| 1131 | + | |
| 1132 | + | |
| 1133 | + | |
| 1134 | + | |
| 1135 | + | |
| 1136 | + | |
| 1137 | + | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
| 1148 | + | |
1093 | 1149 | | |
1094 | 1150 | | |
1095 | 1151 | | |
| |||
0 commit comments