fix(publish): chain build-go after build-c for reliable go generate#381
Merged
DorianZheng merged 3 commits intomainfrom Mar 14, 2026
Merged
fix(publish): chain build-go after build-c for reliable go generate#381DorianZheng merged 3 commits intomainfrom
DorianZheng merged 3 commits intomainfrom
Conversation
…xist build-go's tag-go-module job creates the Go module tag that enables `go get`, but users immediately run `go generate` which downloads the C SDK archive from the release. If build-c hasn't uploaded yet, go generate 404s. Chain build-go after build-c via workflow_run trigger (same pattern as build-runtime chaining after warm-caches). Tag-go-module now reads version from Cargo.toml since the release event context isn't directly available through workflow_run.
The nix crate uses aio_*, timer_*, and mq_* functions that live in librt on glibc < 2.34 (manylinux_2_28 uses glibc 2.28). Without -lrt, go test fails with undefined reference errors on Linux.
… in CI Move all Go SDK source from sdks/go/pkg/boxlite/ to sdks/go/, giving users a cleaner workflow: go get github.com/boxlite-ai/boxlite/sdks/go go generate github.com/boxlite-ai/boxlite/sdks/go go build ./... CI now uses `go generate` instead of manual curl/tar to download the prebuilt C SDK archive, validating the exact end-user workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-go.ymlafterbuild-c.ymlviaworkflow_runtriggergo generate404 errors when users install immediately after releaseCargo.tomlinstead of release event context (not available throughworkflow_run)Test plan
build-c.ymlviaworkflow_dispatch— verifybuild-go.ymlruns after it completesbuild-go.ymlskips ifbuild-c.ymlfailssdks/go/vX.Y.Zis created after C SDK archives are uploaded