fix(ci): add Go to PATH in all manylinux container builds#371
Merged
DorianZheng merged 2 commits intomainfrom Mar 12, 2026
Merged
fix(ci): add Go to PATH in all manylinux container builds#371DorianZheng merged 2 commits intomainfrom
DorianZheng merged 2 commits intomainfrom
Conversation
Commit 210e57b fixed the Go PATH issue in warm-caches.yml but missed build-runtime.yml, build-node.yml, and the Python cibuildwheel config. setup-manylinux.sh installs Go to /usr/local/go/bin in a subshell, but the PATH export is lost when the subshell exits. Pre-add the path so libgvproxy-sys build.rs can find the go binary.
RootfsSpec is an internal Rust type used in options.rs but never registered as a PyO3 class. Its presence in the import list caused the entire native extension import to fail with ImportError, hiding all native types (Boxlite, Box, etc.) from __all__.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/usr/local/go/binto PATH inbuild-runtime.ymlandbuild-node.ymlmanylinux container scripts, matching the existing fix inwarm-caches.yml(commit 210e57b)pyproject.tomlcibuildwheelbefore-allscript and LinuxenvironmentconfigRootfsSpecimport error in Python SDK__init__.py— it was listed as an export but never registered as a PyO3 class, causing all native types to be hidden from__all__Root cause
setup-manylinux.shinstalls Go to/usr/local/go/binin a subshell, but the PATH export is lost when the subshell exits. The subsequentmake runtimetriggerslibgvproxy-sysbuild.rs which callsgo mod downloadand fails with "No such file or directory".Test plan
build-runtimeworkflow passes on Linux manylinux containersbuild-nodeworkflow passes on Linux manylinux containersbuild-wheels(cibuildwheel) workflow passes