fix(ci): add Go to PATH in warm-caches manylinux container#369
Merged
DorianZheng merged 1 commit intomainfrom Mar 12, 2026
Merged
fix(ci): add Go to PATH in warm-caches manylinux container#369DorianZheng merged 1 commit intomainfrom
DorianZheng merged 1 commit intomainfrom
Conversation
setup_go() installs Go to /usr/local/go/bin and exports PATH in a subshell (bash setup-manylinux.sh), but that export is lost when the subshell exits. The subsequent `make runtime` target runs cargo build, whose libgvproxy-sys build script cannot find `go`. Pre-add /usr/local/go/bin to PATH in the container script so it is available when cargo's build scripts run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Warm CachesCI workflow failing in the manylinux Docker container withgo: No such file or directorysetup_go()installs Go to/usr/local/go/binand exports PATH inside a subshell (bash setup-manylinux.sh), but that export is lost when the subshell exits — the subsequentmake runtimecargo build can't findgo/usr/local/go/binto PATH in the container script so it's available when cargo's build scripts runTest plan
Warm Cachesworkflow passes on this PR's push to mainlibgvproxy-syswith Go