fix(build): prevent RUSTFLAGS leaking into vendored libkrun build#353
Merged
DorianZheng merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
CI tools (e.g., actions-rust-lang/setup-rust-toolchain) set RUSTFLAGS=-D warnings, which leaks into the nested cargo subprocess that builds vendored libkrun. This promotes warnings in vendored code (like unused_unsafe in cpuid crate) to errors, breaking the build. Strip RUSTFLAGS and CARGO_ENCODED_RUSTFLAGS from the subprocess environment to isolate the vendored build from outer compiler flags.
DorianZheng
deleted the
fix/prevent-rustflags-leaking-into-vendored-build
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI tools (e.g., actions-rust-lang/setup-rust-toolchain) set RUSTFLAGS=-D warnings, which leaks into the nested cargo subprocess that builds vendored libkrun. This promotes warnings in vendored code (like unused_unsafe in cpuid crate) to errors, breaking the build.
Strip RUSTFLAGS and CARGO_ENCODED_RUSTFLAGS from the subprocess environment to isolate the vendored build from outer compiler flags.