Skip to content

fix(make): exclude cbindgen-generated boxlite.h from clang-format#352

Merged
DorianZheng merged 1 commit intomainfrom
fix/exclude-generated-header-from-clang-format
Mar 6, 2026
Merged

fix(make): exclude cbindgen-generated boxlite.h from clang-format#352
DorianZheng merged 1 commit intomainfrom
fix/exclude-generated-header-from-clang-format

Conversation

@DorianZheng
Copy link
Copy Markdown
Member

Summary

  • Removed sdks/c/include/boxlite.h from fmt:c and fmt:check:c Makefile targets
  • The header is generated by cbindgen and should not be reformatted by clang-format, as it creates noise diffs on every pre-commit hook run
  • .clang-format is retained for formatting hand-written test files in sdks/c/tests/

Test plan

  • Run make fmt:c — only formats test files, does not touch boxlite.h
  • Run make fmt:check:c — only checks test files
  • Pre-commit hook no longer creates spurious diffs on boxlite.h

The generated header was being reformatted on every pre-commit hook run,
creating noise diffs. Only format the hand-written test files.
@DorianZheng DorianZheng merged commit e88dba8 into main Mar 6, 2026
8 of 9 checks passed
@DorianZheng DorianZheng deleted the fix/exclude-generated-header-from-clang-format branch March 6, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant