fix(build): restore build-shim invocation in build-runtime and normal…#320
Merged
DorianZheng merged 1 commit intomainfrom Mar 1, 2026
Merged
fix(build): restore build-shim invocation in build-runtime and normal…#320DorianZheng merged 1 commit intomainfrom
DorianZheng merged 1 commit intomainfrom
Conversation
…ize output path The glibc switch commit (7c55942) accidentally removed the build-shim.sh invocation from build-runtime.sh, causing `make cli` to fail because the shim binary was never built. Changes: - build-runtime.sh: restore build-shim.sh call and SKIP_SHIM_BUILD CI support; simplify shim path to target/$PROFILE/boxlite-shim - build-shim.sh: remove compute_shim_target function; after cargo builds with --target (required to isolate RUSTFLAGS from proc-macro dylib compilation), copy binary to target/$PROFILE/ so all platforms use the same canonical path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ize output path
The glibc switch commit (7c55942) accidentally removed the build-shim.sh invocation from build-runtime.sh, causing
make clito fail because the shim binary was never built.Changes: