refactor(test): migrate health_check.rs to BoxTestBase#311
Merged
DorianZheng merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
…eanup Split BoxTestBase::with_options() to return a created-but-not-started box, allowing tests to observe pre-start state (e.g. HealthState::Starting). new() still returns a running box for convenience. Rewrites health_check.rs to use BoxTestBase instead of a hand-rolled TestContext, eliminating manual TempDir/runtime setup and explicit stop/remove cleanup. Also fixes per-test tmp directory leaks: replaces the persistent /tmp/boxlite-test warm home with an ephemeral TempDir, and introduces LinkedCache as an RAII handle so per-test tmp dirs under target/boxlite-test/tmp/ are cleaned up on drop.
DorianZheng
added a commit
that referenced
this pull request
Feb 27, 2026
… assertion Migrate all 7 jailer integration tests from the ad-hoc JailerTestCtx to the shared BoxTestBase infrastructure, matching the pattern established in #311. Fix the `jailer_enabled_custom_profile_deny_boxes_subpath_blocks_start` test which failed after migration: the sandbox denial now manifests as "File exists" (EEXIST from mkdir when stat() is blocked) rather than "operation not permitted". Add "file exists" as valid deny evidence since create_dir_all only surfaces EEXIST when the sandbox prevents the stat() verification of an existing directory.
3 tasks
DorianZheng
added a commit
that referenced
this pull request
Feb 27, 2026
… assertion (#312) Migrate all 7 jailer integration tests from the ad-hoc JailerTestCtx to the shared BoxTestBase infrastructure, matching the pattern established in #311. Fix the `jailer_enabled_custom_profile_deny_boxes_subpath_blocks_start` test which failed after migration: the sandbox denial now manifests as "File exists" (EEXIST from mkdir when stat() is blocked) rather than "operation not permitted". Add "file exists" as valid deny evidence since create_dir_all only surfaces EEXIST when the sandbox prevents the stat() verification of an existing directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BoxTestBase::with_options()to return a created-but-not-started box, so tests can observe pre-start state (e.g.HealthState::Starting).new()still returns a running box.health_check.rsto useBoxTestBaseinstead of a hand-rolledTestContext, eliminating manual setup and explicit cleanup./tmp/boxlite-testwarm home with ephemeralTempDir, introducesLinkedCacheRAII handle for automatic cleanup.Test plan
cargo clippy -p boxlite-test-utils --tests -- -D warnings— cleancargo clippy -p boxlite --tests -- -D warnings— cleancargo fmt --check— cleancargo test -p boxlite-test-utils— 39/39 passed