feat: shared tar module and copy operations#297
Merged
DorianZheng merged 5 commits intomainfrom Feb 25, 2026
Merged
Conversation
…ode SDK - Extract duplicated tar pack/unpack logic into boxlite-shared::tar - Add copy_in/copy_out to Node.js SDK (SimpleBox) - Add comprehensive integration tests for copy operations - Remove #[ignore] from VM integration tests - Split Node.js test config into unit/integration projects
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- Add install_node_sdk_deps() to setup-common.sh, called from macOS and Ubuntu setup scripts after Node.js installation - Add prettier-missing guard to fmt:node, fmt:check:node targets - Add node_modules-missing guard to lint:node target - Apply prettier formatting to Node SDK (copy.integration.test.ts)
Merge install_python_dev_tools into install_python_sdk_deps to install ruff, pytest, and pytest-asyncio via `pip install -e ".[dev]"` from sdks/python/pyproject.toml. Fixes pre-push hook failure where `make test:unit:python` could not find pytest.
Cloned boxes have a multi-level COW backing chain (clone → source → base image). The seatbelt sandbox only granted read access to the immediate backing file, missing deeper levels. This caused libkrun EINVAL when starting cloned boxes on macOS. Also fix copy test paths from /tmp to /root (tmpfs hides rootfs files).
BoxliteRuntime::new() wipes temp_dir on startup. When all parallel nextest processes shared the same target/boxlite-test/tmp/ directory, one test's cleanup would delete another test's in-progress export files (ENOENT). Create a unique subdirectory per test via tempfile::tempdir_in on the same device, avoiding cross-device rename issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
box_impl.rsandguest/files.rsinto a sharedboxlite-shared::tarmodulecopy_in/copy_outoperations to the Node.js SDK (SimpleBox)#[ignore]from VM integration tests; split Node.js test config into unit/integration projectsTest plan
cargo test -p boxlite-shared— 472 tests passcargo test -p boxlite-ffi— 7 tests passcopy.integration.test.ts)