You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The command to run integration tests now is: BOXLITE_RUNTIME_DIR=$(pwd)/target/boxlite-runtime \ LD_LIBRARY_PATH=$(pwd)/target/boxlite-runtime:$LD_LIBRARY_PATH \ cargo test -p boxlite --test execution_shutdown test_wait_behavior_on_box_stop -- --test-threads=1 --nocapture. After merging this PR, is it no longer necessary to configure environment variables?
The command to run integration tests now is: BOXLITE_RUNTIME_DIR=$(pwd)/target/boxlite-runtime \ LD_LIBRARY_PATH=$(pwd)/target/boxlite-runtime:$LD_LIBRARY_PATH \ cargo test -p boxlite --test execution_shutdown test_wait_behavior_on_box_stop -- --test-threads=1 --nocapture. After merging this PR, is it no longer necessary to configure environment variables?
Hi @uran0sH. The integration tests issue will be fixed ASAP. The root cause is I accidentally set BOXLITE_RUNTIME_DIR to OUT_DIR=runtime. However, OUT_DIR=runtime doesn't contain boxlite-guest which leads to binary not found issue. This PR haven't fixed it yet. Will file another PR for the test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target/boxlite-runtimein local dev/tests (prevents unsigned shim selection on macOS)start()before asserting active/stopped statesVerification
make runtime-debugcargo check -p boxlitemake test:rustcargo test -p boxlite --test execution_shutdown test_all_waits_return_on_stop -- --test-threads=1 --nocapture