fix(guest): fd double-close in spawn_with_pipes causing exec crash#268
Merged
DorianZheng merged 1 commit intomainfrom Feb 15, 2026
Merged
fix(guest): fd double-close in spawn_with_pipes causing exec crash#268DorianZheng merged 1 commit intomainfrom
DorianZheng merged 1 commit intomainfrom
Conversation
nix 0.29's pipe() returns (OwnedFd, OwnedFd). The code passed these to Stdio::from_raw_fd() via as_raw_fd(), which borrows without transferring ownership. Both OwnedFd and Stdio then owned the same fd, triggering "IO Safety violation: owned file descriptor already closed" when the OwnedFd was dropped. Switch to into_raw_fd() to properly transfer ownership, and remove the now-unnecessary drop() calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BOXLITE_EXECUTOR=guestcauses transport error #264GuestExecutor::spawn_with_pipes()that crashed the guest agent on everyexeccallnix 0.29'spipe()returns(OwnedFd, OwnedFd), but the code usedas_raw_fd()(borrow) instead ofinto_raw_fd()(transfer ownership) when passing fds toStdio::from_raw_fd(), creating dual ownership and triggering Rust's IO safety abortinto_raw_fd()and remove the now-unnecessarydrop()callsTest plan
cargo check -p boxlite-guest --target aarch64-unknown-linux-muslpassesboxlite exec -e BOXLITE_EXECUTOR=guest <box> -- echo "Hello World"prints output (previously crashed with transport error)boxlite exec <box> -- echo "Hello from container"still works (container executor regression check)