fix(ci): respect CARGO_HOME in setup scripts for manylinux builds#242
Merged
DorianZheng merged 1 commit intomainfrom Feb 12, 2026
Merged
fix(ci): respect CARGO_HOME in setup scripts for manylinux builds#242DorianZheng merged 1 commit intomainfrom
DorianZheng merged 1 commit intomainfrom
Conversation
The manylinux container sets CARGO_HOME=/work/.cargo-manylinux for
cargo registry caching, but setup scripts hardcoded $HOME/.cargo/env.
After rustup installs to $CARGO_HOME, sourcing $HOME/.cargo/env fails.
- Use ${CARGO_HOME:-$HOME/.cargo} in all cargo env references
(setup-common.sh, common.sh) — backwards-compatible fallback
- Cache only registry/ and git/ subdirs, not bin/ — avoids stale
rustup proxy issue on cache hit (proxies exist but RUSTUP_HOME
is ephemeral in container, causing false positive in check_rust)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the manylinux runtime build failure from #241.
$HOME/.cargo/envbut the manylinux container setsCARGO_HOME=/work/.cargo-manylinux, so rustup creates the env file at$CARGO_HOME/envinstead${CARGO_HOME:-$HOME/.cargo}everywhere (backwards-compatible fallback)registry/andgit/subdirs, notbin/— avoids stale rustup proxy issue on second CI runTest plan
build-runtimeworkflow passes (manylinux container)CARGO_HOMEunset, falls back to$HOME/.cargo)CARGO_HOME)