Remove TaskProgressModel and store progress in TaskModel.progress_count #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 83.69% 83.14% -0.55%
==========================================
Files 35 39 +4
Lines 791 795 +4
==========================================
- Hits 662 661 -1
- Misses 129 134 +5
Continue to review full report at Codecov.
|
jedie
force-pushed
the
refactor-models
branch
6 times, most recently
from
8c753c5 to
828e260
Compare
Remove the `TaskProgressModel` and store progress information directly into `TaskModel`. The existing TaskProgressModel progress information will be migrated into `TaskModel` ;) Also store the current progress count into `SignalInfoModel` instance: So it is stored at which progress the signal was generated. Add `TaskModel.cumulate_progress` field that indicates if progress of the sub tasks be added up and saved in the parent task. Add `TaskModel.finished` field that indicates that this Task no longer waits or run. Idea comes from: #57 (comment)
jedie
force-pushed
the
refactor-models
branch
from
828e260 to
0b92aac
Compare
jedie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
TaskProgressModeland store progress information directly intoTaskModel.The existing TaskProgressModel progress information will be migrated into
TaskModel;)Also store the current progress count into
SignalInfoModelinstance: So it is stored at whichprogress the signal was generated.
Add
TaskModel.cumulate_progressfield that indicates if progress of the sub tasks be added up andsaved in the parent task.
Add
TaskModel.finishedfield that indicates that this Task no longer waits or run.Idea comes from: #57 (comment)