Use darker as code formatter tool base... #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 1, 2022 09:56
Use Darker as code formatter. Darker is: """ Apply black reformatting to Python files only in regions changed since a given commit. """ Also use `pytest-darker`, `pytest-flake8` and `pytest-isort` ... So code formatting "errors" will be check in pytest run. (Note: Only the first test is slower, afer one test runs only changed files will be checked.)
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=======================================
Coverage 83.56% 83.56%
=======================================
Files 35 35
Lines 791 791
=======================================
Hits 661 661
Misses 130 130 Continue to review full report at Codecov.
|
phihag
reviewed
Feb 1, 2022
jedie
pushed a commit
that referenced
this pull request
Feb 3, 2022
Code check is done in pytest run, since: #74 And there is a problem with 'fix-code-style', because of: akaihola/darker#273 (black would like to access docker volumes and raise a permission error)
jedie
pushed a commit
that referenced
this pull request
Feb 3, 2022
There is no need to test linting separately, because this is done in pytest run since: #74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Darker as code formatter. Darker is:
"""
Apply black reformatting to Python files only in regions changed since a given commit.
"""
Also use
pytest-darker,pytest-flake8andpytest-isort... So code formatting "errors" will becheck in pytest run. (Note: Only the first test is slower, afer one test runs only changed files
will be checked.)
Based on #73