fix: expire typing indicators after 10 seconds - #538
Merged
Conversation
boxdot
approved these changes
May 12, 2026
Typing indicators now auto-expire after 10 seconds per Signal protocol. Previously, [T] would persist forever if the Stopped message was lost. Closes boxdot#151
MarkAtwood
force-pushed
the
fix/issue-151
branch
from
July 10, 2026 22:16
1f38da1 to
26b3812
Compare
Contributor
Author
|
Rebased onto current main. The typing-expiry call now sits in the shared Event::Tick handler alongside the disappearing-messages expiry, and the channel constructors keep the new expire_timer field. cargo test: 54 passed. |
boxdot
enabled auto-merge (squash)
July 11, 2026 17:08
Owner
|
Thank you |
boxdot
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing indicators now auto-expire after 10 seconds per Signal protocol.
Previously,
[T]would persist forever if theStoppedmessage was lost.Changes
TypingSetnow storesInstanttimestamps instead of just presenceChannel::expire_typing()to remove stale indicatorsApp::expire_typing_indicators()called every tick (~1s)TYPING_TIMEOUT_SECS = 10Test plan
cargo testpassesCloses #151