fix: remove stray previous() in select_next_channel - #533
Merged
Conversation
PR boxdot#524 added self.channels.previous() after self.channels.next() in select_next_channel(), which cancels the movement. The down arrow key (and ctrl+j) no longer advance to the next channel. Remove the erroneous previous() call to restore correct behavior.
Owner
|
Thanks! Looks like it got in when fixing the merge conflict. I should have tried out the app manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #532
PR #524 added
self.channels.previous()afterself.channels.next()inselect_next_channel(), which cancels the movement. The down arrow key(and ctrl+j) no longer advance to the next channel.
Remove the erroneous
previous()call to restore correct behavior.