fix: parse binary fields in messages - #504
Merged
Merged
Conversation
Signal introduced new fields with _binary suffix that replace their string counterparts. This commit adds support for those fields. Some messages were missing, because their string fields were replaced and not used anymore, and so they were dropped by the handler.
boxdot
pushed a commit
that referenced
this pull request
Jul 11, 2026
see also: #504 On modern clients, `Quote::author_aci` is `None`, with `Quote::author_aci_binary` being where the data lives. The logic of `Message::from_quote` caused these "modern quotes" to be dropped and not displayed. Instead, use `parse_uuid` to parse them, checking both `Quote::author_aci_binary` and `Quote::author_aci`. Also, in outgoing messages, use `Quote::author_aci_binary` instead of `Quote::author_aci`, to be modern ourselves too. ([We already do this for reactions](https://github.com/boxdot/gurk-rs/blob/2d41dddd4eff6f64f8318157afcc1038bb7f8315/src/signal/impl.rs#L293-L294))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signal introduced new fields with _binary suffix that replace their
string counterparts. This commit adds support for those fields. Some
messages were missing, because their string fields were replaced and not
used anymore, and so they were dropped by the handler.
Also fix missing reactions.