feat(#347): add editor mode with configurable ctrl-o keybind - #488
Merged
Conversation
Koleok
force-pushed
the
koleok/347-editor-mode
branch
from
March 4, 2026 14:18
ce316e9 to
2da8dc0
Compare
Koleok
force-pushed
the
koleok/347-editor-mode
branch
from
March 7, 2026 21:33
5053bfc to
ad32823
Compare
Contributor
Author
|
Keeping it rebased :) I've been using this in daily driver mode for about a week, smooth sailing so far. |
Owner
|
Thank you for implementing and testing this advanced feature! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
ctrl-oto open the system$EDITORwhile the input is focused, composing the message externally and populating the input box on save. The binding is registered as theopen_editorcommand in the normal mode keybinding table, user-overridable viagurk.tomllike any other binding. Editor resolution ($VISUAL→$EDITOR→ fallback list), temp file lifecycle, and subprocess management are handled by theeditcrate.The crossterm
EventStreamtask is aborted before the terminal is released and respawned after the TUI resumes, giving the editor exclusive access to stdin for the full session and keeping the terminal fd race-free throughout.